[plasma-shell] [Bug 332003] Regression: Task manager does not show thumbnails for minimized windows

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=332003

--- Comment #1 from Martin Gräßlin <mgraesslin-***@public.gmane.org> ---
(In reply to comment #0)

You can assign this to kwin.. but I was not sure.

no, thumbnails are not provided by KWin.

I just tested and cannot reproduce. Is it related to the window being minimized
when plasma starts?

[Bhushan Shah]

https://bugs.kde.org/show_bug.cgi?id=332003

--- Comment #2 from Bhushan Shah <bhush94-***@public.gmane.org> ---
Created attachment 85526
--> https://bugs.kde.org/attachment.cgi?id=85526&action=edit
bug screenshot

Test case

1) Open more then 2 windows.
2) Maximize one and keep two window minimized
3) Hover on minimized one

Again happens only if you have more then 2 windows open.

[Marco Martin]

https://bugs.kde.org/show_bug.cgi?id=332003

Marco Martin <notmart-***@public.gmane.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |notmart-***@public.gmane.org

--- Comment #3 from Marco Martin <notmart-***@public.gmane.org> ---
isn't always been *normal* for minimized windows not having thumbnails? (since
they are not mapped?)

[Bhushan Shah]

https://bugs.kde.org/show_bug.cgi?id=332003

--- Comment #4 from Bhushan Shah <bhush94-***@public.gmane.org> ---
No in Plasma 1 we have thumbnails for them also.

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=332003

--- Comment #5 from Martin Gräßlin <mgraesslin-***@public.gmane.org> ---
(In reply to comment #4)

Post by Bhushan Shah
No in Plasma 1 we have thumbnails for them also.

no, Marco is right. KWin just has a hack to keep them. This hack is still
present and should also work for Plasma. But if Plasma and/or KWin gets started
when the window is already minimized it won't work.

Anyway -> RESOLVED WAYLAND :-)

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=332003

--- Comment #6 from Eike Hein <hein-***@public.gmane.org> ---
Hmm I considered if it wouldn't look nicer to hide the thumbnail item when
there's no data, since it would prevent unsightly scaling and draw less
attention to the fact that something is missing, but one problem with that is
the tooltip for window groups - when there are n windows expected, just
omitting one is very confusing.

[Luiz Angelo De Luca]

https://bugs.kde.org/show_bug.cgi?id=332003

Luiz Angelo De Luca <luizluca-***@public.gmane.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |luizluca-***@public.gmane.org

--- Comment #8 from Luiz Angelo De Luca <luizluca-***@public.gmane.org> ---
Would it be difficult to just get a screenshot before the window is minimized
and show it at the thumbnail? Just make it visually different, like in gray
scale (that is already used visual information for frozen app/image)

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=332003

David Edmundson <kde-K9B6GWZOjNKs88QFB9wrT9Bc4/***@public.gmane.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
CC| |kde-K9B6GWZOjNKs88QFB9wrT9Bc4/***@public.gmane.org
Ever confirmed|0 |1

--- Comment #11 from David Edmundson <kde-K9B6GWZOjNKs88QFB9wrT9Bc4/***@public.gmane.org> ---
If Kwin managed to do it previously, I don't see why it's impossible for plasma
now.

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=332003

--- Comment #12 from Martin Gräßlin <mgraesslin-***@public.gmane.org> ---
(In reply to comment #11)

Post by David Edmundson
If Kwin managed to do it previously, I don't see why it's impossible for
plasma now.

well it's complex :-) KWin keeps the last pixmap, but KWin already has the
pixmap. But Plasma doesn't have a pixmap all the time. When the thumbnail gets
shown the window is minimized, the pixmap is not around and thus it cannot get
the texture. The same happens for KWin when restarting the compositor with
minimized windows. For those KWin also doesn't have pixmaps.

What should work (haven't tried) is setting "Keep window thumbnails" to
"Always" in the Compositing KCM.

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=332003

--- Comment #13 from Eike Hein <hein-***@public.gmane.org> ---
Martin,

can you add a prop for "I don't have a pixmap for this" to
PlasmaCore.WindowThumbnail, or an invokable(winid)?

That's a prerequisite for pursueing anything like #6, which would probably look
like this in practice: For single-window tooltips, simply hide the whole
thumbnail section; for group tooltips, replace the thumb with some sort of
"don't have data" icon item.

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=332003

Post by Eike Hein
can you add a prop for "I don't have a pixmap for this" to
PlasmaCore.WindowThumbnail, or an invokable(winid)?

yes that can be done, but requires quite some rework to get all the fallback
to the icon removed (that doesn't make sense in that case). As that's quite
some code and uses two different implementations (GLX and EGL) my
recommendation would be to delay this to frameworks 5.1

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=332003

--- Comment #15 from Eike Hein <hein-***@public.gmane.org> ---
No objections. Would you like a separate ticket for the component change with
you as assignee?

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=332003

--- Comment #16 from Eike Hein <hein-***@public.gmane.org> ---
Actually, I think it does make sense to track these separately, let me just set
that up real quick.

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=332003

Eike Hein <hein-***@public.gmane.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Depends on| |336524
Summary|Regression: Task manager |Adapt visualization when
|does not show thumbnails |window thumbnail data is
|for minimized windows |not available for tooltip

--- Comment #17 from Eike Hein <hein-***@public.gmane.org> ---
Updating title and adding bug 336524 to depends.

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=332003
Bug 332003 depends on bug 336524, which changed state.

Bug 336524 Summary: WindowThumbnail should have a property or invokable to read 'thumbnail not available' state
https://bugs.kde.org/show_bug.cgi?id=336524

What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=332003

Kai Uwe Broulik <***@privat.broulik.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@wi.rr.com

--- Comment #18 from Kai Uwe Broulik <***@privat.broulik.de> ---
*** Bug 367670 has been marked as a duplicate of this bug. ***

[Dr. Chapatin]

https://bugs.kde.org/show_bug.cgi?id=332003

Dr. Chapatin <***@gmx.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmx.com

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=332003

Nate Graham <***@zoho.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@zoho.com

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=332003

Nate Graham <***@zoho.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@yahoo.com

--- Comment #19 from Nate Graham <***@zoho.com> ---
*** Bug 363800 has been marked as a duplicate of this bug. ***

[Pekka Helenius]

https://bugs.kde.org/show_bug.cgi?id=332003

Pekka Helenius <***@hotmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@hotmail.com

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=332003

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |ksthiele+***@gmail.com

--- Comment #20 from Nate Graham <***@kde.org> ---
*** Bug 392774 has been marked as a duplicate of this bug. ***

[Henrique Sant'Anna]

https://bugs.kde.org/show_bug.cgi?id=332003

Henrique Sant'Anna <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

[Henrique Sant'Anna]

https://bugs.kde.org/show_bug.cgi?id=332003

--- Comment #21 from Henrique Sant'Anna <***@gmail.com> ---
The tooltip should look the same or very similar no matter if the window is
minimized or not. It means that if there are a particular window that is
minimized and another one that is not, both windows should get the preview of
the window content or both windows should not. That's an UX issue.
One way to workaround that is to do a window screenshot when minimizing it and
than use the static screenshot as the window preview while it is minimized,
like suggested at comment #8.