[krita] [Bug 349538] New: [Layer] selection highlight of active layer disappear after leaving settings

[David REVOY]

https://bugs.kde.org/show_bug.cgi?id=349538

Bug ID: 349538
Summary: [Layer] selection highlight of active layer disappear
after leaving settings
Product: krita
Version: 2.9
Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: Layer Stack
Assignee: krita-bugs-***@kde.org
Reporter: ***@davidrevoy.com

Hi, it's a bug I track since a long time : sometime, the active layer selection
disappears ; the stack show all layers, but no one is selected. You can paint,
do actions, etc... but this state increases a lot the risk of crash. That's why
I started to look in details 'when the layer selection disappears'. I found one
:

How to reproduce
------------------------
1. Open a *.kra multilayered document
2. Paint on a layer
3. Open the settings ( menu : Settings > Configure Krita )
4. Press 'OK' to the preferences dialog

Result :
----------
Active layer selected is no longer selected.

[Stefano Bonicatti]

https://bugs.kde.org/show_bug.cgi?id=349538

Stefano Bonicatti <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
CC| |***@gmail.com
Ever confirmed|0 |1

--- Comment #1 from Stefano Bonicatti <***@gmail.com> ---
Nice finding, i can confirm ;).

[Stefano Bonicatti]

https://bugs.kde.org/show_bug.cgi?id=349538

--- Comment #2 from Stefano Bonicatti <***@gmail.com> ---
This issue arise because KisNodeModel::updateSettings calls reset(), which
deselects everything.
I'm not exactly sure why it does that and what should be the correct fix (store
which layers were selected before the reset and then restore them? Or select
only the first layer?).

[David REVOY]

https://bugs.kde.org/show_bug.cgi?id=349538

--- Comment #3 from David REVOY <***@davidrevoy.com> ---
On a usage point-of-view, I would prefer to keep my layer selected the whole
Krita session ; for all documents opened in viewports. Sometime I just change
the 'transparency checker pattern' in the settings, or other settings. I
imagine I would do painting mistakes if I had my layer selection jumping to the
bottom of the stack just because I closed my Krita settings. ( but I understand
a fallback on the first layer of the stack can be an easier way fix to do. )

[Stefano Bonicatti]

https://bugs.kde.org/show_bug.cgi?id=349538

--- Comment #4 from Stefano Bonicatti <***@gmail.com> ---
Git commit 0efd3929d1bad3f1abff8bcccd16ecc7d20dc13c by Stefano Bonicatti.
Committed on 27/06/2015 at 21:12.
Pushed by stefanobonicatti into branch 'calligra/2.9'.

Fix layer selection clearing when the model resets

Created slotModelReset slot function in KisLayerBox to substitute the
modelReset signal
connection to updateUI so that is possible to restore the selection after the
model resets.

Added some checks to avoid model reset when not needed.

Added hasDummiesFacade function to KisNodeModel so that it is possible to check
when its dummiesFacade
is null due to code that temporarily unset it, to avoid using its functions and
crash.

Added even more checks to avoid duplicated work when setting something that is
already set (setting the same canvas twice).

M +23 -1
krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp
M +1 -0 krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.h
M +21 -4 krita/ui/kis_node_model.cpp
M +1 -0 krita/ui/kis_node_model.h

http://commits.kde.org/calligra/0efd3929d1bad3f1abff8bcccd16ecc7d20dc13c

[David REVOY]

https://bugs.kde.org/show_bug.cgi?id=349538

David REVOY <***@davidrevoy.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED

--- Comment #5 from David REVOY <***@davidrevoy.com> ---
@Stephano ; thanks for the commit, it solved the issue.
I mark it as 'RESO' then.