[plasmashell] [Bug 401023] New: Duplicated icons

[Oleg Solovyov]

https://bugs.kde.org/show_bug.cgi?id=401023

Bug ID: 401023
Summary: Duplicated icons
Product: plasmashell
Version: master
Platform: Other
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: Desktop Containment
Assignee: ***@kde.org
Reporter: ***@altlinux.org
CC: plasma-***@kde.org
Target Milestone: 1.0

Created attachment 116301
--> https://bugs.kde.org/attachment.cgi?id=116301&action=edit
Duplicated icon

SUMMARY
When I create a new folder between two existing adjacent icons the one I just
created is duplicated like in BUG#398864

STEPS TO REPRODUCE
1. Create a new user
2. Log in
3. Create a new folder between existing icons

OBSERVED RESULT
The icon just created is duplicated but I can iteract with only one copy of it
(see attachment)

EXPECTED RESULT
Icon should not be duplicated

SOFTWARE/OS VERSIONS
Linux: 4.19.1-un-def-alt1
KDE Plasma Version: 5.12.7
KDE Frameworks Version: 5.51.0
Qt Version: 5.11.2

ADDITIONAL INFORMATION
I successfully reproduced that error in master branch and the NEON Developer
Edition

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=401023

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|REPORTED |RESOLVED
CC| |***@kde.org
Resolution|--- |DUPLICATE

--- Comment #1 from Nate Graham <***@kde.org> ---
It's the same issue, it's just that the fix isn't released yet. It'll be fixed
in 5.12.8, but you still have 5.12.7, because 5.12.8 isn't released yet. If you
need relief now, ask your distro to backport the fix.

*** This bug has been marked as a duplicate of bug 398864 ***

[Oleg Solovyov]

https://bugs.kde.org/show_bug.cgi?id=401023

Oleg Solovyov <***@altlinux.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|DUPLICATE |---
Ever confirmed|0 |1
Status|RESOLVED |REOPENED

--- Comment #2 from Oleg Solovyov <***@altlinux.org> ---
It's not the same issue.

I already patched my 5.12.7 against #398864 and _this_ issue still reproduces,
while 398864 is fixed.

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=401023

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@kde.org,
| |***@privat.broulik.de

--- Comment #3 from Nate Graham <***@kde.org> ---
Darn.

Eike or Kai, any ideas?

--- Comment #4 from Nate Graham <***@kde.org> ---
Darn.

Eike or Kai, any ideas?

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=401023

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@kde.org,
| |***@privat.broulik.de

--- Comment #3 from Nate Graham <***@kde.org> ---
Darn.

Eike or Kai, any ideas?

--- Comment #4 from Nate Graham <***@kde.org> ---
Darn.

Eike or Kai, any ideas?

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=401023

--- Comment #5 from Nate Graham <***@kde.org> ---
Created attachment 116377
--> https://bugs.kde.org/attachment.cgi?id=116377&action=edit
Reproduction of the issue

I just accidentally reproduced and confirmed the issue by copying four items to
the desktop. Thereafter, duplicates of all four are created, and interacting
with one also modified its phantom copy. It's really weird.

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=401023

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |grave
Priority|NOR |VHI

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=401023

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Keywords| |usability
Status|REOPENED |CONFIRMED

[Oleg Solovyov]

https://bugs.kde.org/show_bug.cgi?id=401023

--- Comment #6 from Oleg Solovyov <***@altlinux.org> ---
Reproduced this on Plasma 5.14.3 + Qt 5.9.6

[Oleg Solovyov]

https://bugs.kde.org/show_bug.cgi?id=401023

--- Comment #7 from Oleg Solovyov <***@altlinux.org> ---
Found a possible clue: it happens every time I create an icon when
~/.config/plasma-org.kde.plasma.desktop-appletsrc is missing

[Oleg Solovyov]

https://bugs.kde.org/show_bug.cgi?id=401023

--- Comment #8 from Oleg Solovyov <***@altlinux.org> ---
Found a typo in 98d56d913:

@@ -547,6 +566,8 @@ void Positioner::sourceRowsAboutToBeInserted(const
QModelIndex &parent, int star
}
} else {
emit beginInsertRows(parent, start, end);
+ beginInsertRows(parent, start, end);
+ m_beginInsertRowsCalled = true;
}
}

Is it intentional or committer forgot to remove emit in that patch?

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=401023

--- Comment #9 from Nate Graham <***@kde.org> ---
Oleg, does changing that fix the issue?

[Oleg Solovyov]

https://bugs.kde.org/show_bug.cgi?id=401023

--- Comment #10 from Oleg Solovyov <***@altlinux.org> ---
(In reply to Nate Graham from comment #9)

Post by Nate Graham
Oleg, does changing that fix the issue?

Unfortunately, no

[Oleg Solovyov]

https://bugs.kde.org/show_bug.cgi?id=401023

--- Comment #11 from Oleg Solovyov <***@altlinux.org> ---
Commented out the whole connect at foldermodel.cpp:157 and it fixes the issue
O_o

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=401023

David Edmundson <***@davidedmundson.co.uk> changed:

What |Removed |Added
----------------------------------------------------------------------------

Post by Oleg Solovyov
Is it intentional or committer forgot to remove emit in that patch?

emit is a #define for ""

it does nothing, it's just a nice hint if you read the code that we're
releasing flow control and other things might run.

[Oleg Solovyov]

https://bugs.kde.org/show_bug.cgi?id=401023

--- Comment #13 from Oleg Solovyov <***@altlinux.org> ---
(In reply to David Edmundson from comment #12)

Post by David Edmundson

Post by Oleg Solovyov
Is it intentional or committer forgot to remove emit in that patch?

emit is a #define for ""
it does nothing, it's just a nice hint if you read the code that we're
releasing flow control and other things might run.

that's not the point. The point is calling the function twice. Is it ok?

[Oleg Solovyov]

https://bugs.kde.org/show_bug.cgi?id=401023

--- Comment #14 from Oleg Solovyov <***@altlinux.org> ---
(In reply to Oleg Solovyov from comment #11)

Post by Oleg Solovyov
Commented out the whole connect at foldermodel.cpp:157 and it fixes the
issue O_o

also commented out the connect ap positioner.cpp:912 and it fixes the issue
again.

Looks like the slots were invoked by the same signal are doing the same job

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=401023

--- Comment #15 from David Edmundson <***@davidedmundson.co.uk> ---
Oh, I misunderstood.

It certainly doesn't look intentional.

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=401023

--- Comment #16 from Eike Hein <***@kde.org> ---
Indeed, looks like a bona-fide bug. David, since you're currently working on
this code, can you roll it into your other patch or so?