Discussion:
[Discover] [Bug 390349] New: Move "Help" menu onto the GlobalDrawer (orsome other globally-available location) with an appropriate UI
Add Reply
Nate Graham
2018-02-12 23:01:10 UTC
Reply
Permalink
https://bugs.kde.org/show_bug.cgi?id=390349

Bug ID: 390349
Summary: Move "Help" menu onto the GlobalDrawer (orsome other
globally-available location) with an appropriate UI
Product: Discover
Version: 5.12.0
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: discover
Assignee: ***@kde.org
Reporter: ***@zoho.com
Target Milestone: ---

This will remove it from the Settings page's header, which will let us put the
window title there and rename it to be "Sources".
--
You are receiving this mail because:
You are watching all bug changes.
Nate Graham
2018-02-12 23:01:21 UTC
Reply
Permalink
https://bugs.kde.org/show_bug.cgi?id=390349

Nate Graham <***@zoho.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Blocks| |389717


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=389717
[Bug 389717] Settings page: rename to be "Sources" and put the page title in
the header
--
You are receiving this mail because:
You are watching all bug changes.
Aleix Pol
2018-03-02 15:35:53 UTC
Reply
Permalink
https://bugs.kde.org/show_bug.cgi?id=390349

--- Comment #1 from Aleix Pol <***@kde.org> ---
Where would you put this, in master?

Would it make sense to move this menu as a context action in the featured page?
--
You are receiving this mail because:
You are watching all bug changes.
Aleix Pol
2018-03-02 15:36:02 UTC
Reply
Permalink
https://bugs.kde.org/show_bug.cgi?id=390349

Aleix Pol <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0 |1
--
You are receiving this mail because:
You are watching all bug changes.
Nate Graham
2018-03-02 20:58:16 UTC
Reply
Permalink
https://bugs.kde.org/show_bug.cgi?id=390349

--- Comment #2 from Nate Graham <***@kde.org> ---
Honestly I'd add a real menu bar with a full "Help" menu. The issue is that
this isn't really page-specific at all; it's global. No matter where we put it,
if it's not globally-available, it's not really the right location.

As a next-best option, we could put it on the globalDrawer, which is our only
other mostly-globally-visible UI element.
--
You are receiving this mail because:
You are watching all bug changes.
Aleix Pol
2018-03-02 23:42:07 UTC
Reply
Permalink
https://bugs.kde.org/show_bug.cgi?id=390349

--- Comment #3 from Aleix Pol <***@kde.org> ---
After all the work we've done to save the work the banner used, I'm not wasting
50px of vertical space only to add a menu bar with just the one menu with 2
items.

They may be global, but they don't need to be accessible at all times.
Remember we are talking about "About Discover" and "Report a bug".
--
You are receiving this mail because:
You are watching all bug changes.
Thomas Pfeiffer
2018-11-08 16:31:10 UTC
Reply
Permalink
https://bugs.kde.org/show_bug.cgi?id=390349

Thomas Pfeiffer <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@kde.org

--- Comment #4 from Thomas Pfeiffer <***@kde.org> ---
Putting it in the global drawer makes perfect sense. As Nate said, it's not
specific to any page, which is exactly what the global drawer is for.
--
You are receiving this mail because:
You are watching all bug changes.
Aleix Pol
2018-11-08 17:23:30 UTC
Reply
Permalink
https://bugs.kde.org/show_bug.cgi?id=390349

Aleix Pol <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/dis
| |cover/078dd8e1096b307f44639
| |e5c95d1dae7f1ca5039
Status|CONFIRMED |RESOLVED

--- Comment #5 from Aleix Pol <***@kde.org> ---
Git commit 078dd8e1096b307f44639e5c95d1dae7f1ca5039 by Aleix Pol.
Committed on 08/11/2018 at 17:18.
Pushed by apol into branch 'master'.

Move settings contextual menu into the drawer, under "Help"

M +17 -0 discover/qml/DiscoverDrawer.qml
M +0 -5 discover/qml/SourcesPage.qml

https://commits.kde.org/discover/078dd8e1096b307f44639e5c95d1dae7f1ca5039
--
You are receiving this mail because:
You are watching all bug changes.
Nate Graham
2018-11-09 00:22:13 UTC
Reply
Permalink
https://bugs.kde.org/show_bug.cgi?id=390349

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |5.15.0
--
You are receiving this mail because:
You are watching all bug changes.
Loading...