[kscreenlocker] [Bug 395671] New: presing enter key on lockscreen wont focus returning unlocking failed

[neousr]

https://bugs.kde.org/show_bug.cgi?id=395671

Bug ID: 395671
Summary: presing enter key on lockscreen wont focus returning
unlocking failed
Product: kscreenlocker
Version: unspecified
Platform: Neon Packages
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: greeter
Assignee: plasma-***@kde.org
Reporter: ***@protonmail.com
CC: ***@gmail.com
Target Milestone: ---

KDE Neon 5.13 User edition

Version: 5.13.1

After locking the system pressing enter will show the user and password prompt
but it will not focus on the password box saying 'Unlocking failed' even if no
password was actually typed.

Steps to Reproduce:

Lock the session
Press Enter
Unlocking failed message

After the error shows the box will regain focus allowing to enter the system.

[neousr]

https://bugs.kde.org/show_bug.cgi?id=395671

neousr <***@protonmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|presing enter key on |Pressing enter key on
|lockscreen wont focus |lockscreen wont focus
|returning unlocking failed |returning unlocking failed

[neousr]

https://bugs.kde.org/show_bug.cgi?id=395671

--- Comment #1 from neousr <***@protonmail.com> ---
Additional info:

OS KDE Neon 5.13 User edition

Version: 5.13.1

KDE Framework 5.47.0

QT Version 5.11.0

Waking the system from sleep mode will have the same effect.

And corrected a typo on the title. Sorry about the double notification.

[Neousr]

https://bugs.kde.org/show_bug.cgi?id=395671

--- Comment #2 from Neousr <***@protonmail.com> ---
Created attachment 113543
--> https://bugs.kde.org/attachment.cgi?id=113543&action=edit
lockscreen error

Adding a webm with the bug on action.

Steps to Reproduce:

1- Lock the screen
2- Wait until the username disappears
3- Press Enter

Unlocking failed message.

This bug is pretty similar to the one on 5.10 ID 380491
https://bugs.kde.org/show_bug.cgi?id=380491

It started to happen when the new blur effect debuted on 5.13.

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=395671

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@kde.org,
| |***@gmail.com

[Dr. Chapatin]

https://bugs.kde.org/show_bug.cgi?id=395671

Dr. Chapatin <***@gmx.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmx.com

--- Comment #3 from Dr. Chapatin <***@gmx.com> ---
Also reproducible with plasma 5.13.4 on Arch Linux.

[Alexander Potashev]

https://bugs.kde.org/show_bug.cgi?id=395671

Alexander Potashev <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

[b***@kde.org]

https://bugs.kde.org/show_bug.cgi?id=395671

***@gmx.net changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmx.net

[Thomas Surrel]

https://bugs.kde.org/show_bug.cgi?id=395671

Thomas Surrel <***@protonmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REPORTED |RESOLVED
Latest Commit| |https://commits.kde.org/pla
| |sma-workspace/754efdedd4ee1
| |b7dbafda06bd7858e2f51346ea0

--- Comment #4 from Thomas Surrel <***@protonmail.com> ---
Git commit 754efdedd4ee1b7dbafda06bd7858e2f51346ea0 by Thomas Surrel.
Committed on 17/10/2018 at 20:53.
Pushed by thsurrel into branch 'Plasma/5.14'.

[Lock Screen] Do not try to unlock when unvisible

Summary:
In the lock screen, pressing the enter key while the UI is not yet
visible ends up trying to unlock (and would usually fail because the
password field is empty).
Ensure that the UI is visible before unlocking.

Test Plan:
Lock the session, press enter. The UI should appear without any
"Unlocking failed" message.

Reviewers: #plasma, #vdg, ngraham, davidedmundson

Reviewed By: #plasma, #vdg, ngraham, davidedmundson

Subscribers: ngraham, davidedmundson, abetts, filipf, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D16219

M +1 -0 lookandfeel/contents/lockscreen/LockScreenUi.qml
M +6 -1 lookandfeel/contents/lockscreen/MainBlock.qml

https://commits.kde.org/plasma-workspace/754efdedd4ee1b7dbafda06bd7858e2f51346ea0

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=395671

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |5.14.2

[Neousr]

https://bugs.kde.org/show_bug.cgi?id=395671

--- Comment #5 from Neousr <***@protonmail.com> ---
Just tried this on neon unstable all the interactions/combinations work as
expected (Enter, Intro and Escape). Waiting until this lands on 5.14.2.
Appreciated.