[krita] [Bug 364162] New: Copy Paste to Frame

[Leonardo Kaempf via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364162

Bug ID: 364162
Summary: Copy Paste to Frame
Product: krita
Version: 3.0
Platform: MS Windows
OS: MS Windows
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: Animation
Assignee: krita-bugs-***@kde.org
Reporter: outcast-and-his-***@hotmail.de

When pasting pixel-informations to a specific Frame, Krita generates a new
Layer.
And when merging this layer to my animated one, the pixel-information got
merged into every single Frame.

Reproducible: Always

Steps to Reproduce:
1. select pixel from anywhere
2. select one frame in some random Layer and paste the copied Pixel-Information
while you have highlighted the Frame which you want to paste to
3. Krita creates a new layer called [random Layer (pasted)]
4. Select the both layers you want to merge and highlight the frame you want to
add the pixel-information
5. merge

Actual Results:
the pixel-information was pasted into every frame in the layer which I wanted
it to be merged to

Expected Results:
I wanted the pixel-information only in the highlighted frame;
and i wanted the possibility to paste directly to paste to a layer/frame

I don’t know if this is a bug-report or a feature-request, but the absence of
the mechanism to copy Pixel from one Frame to another limits working with the
animation-system very much.

[Scott Petrovic via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364162

Scott Petrovic <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com
Ever confirmed|0 |1
Status|UNCONFIRMED |CONFIRMED
Severity|normal |wishlist

--- Comment #1 from Scott Petrovic <***@gmail.com> ---
This would be a feature request. There is no way for Krita to know now if you
want to paste your clipboard content into a layer, or paste your clipboard
content into an animation frame.

[b***@kde.org]

https://bugs.kde.org/show_bug.cgi?id=364162

***@gmail.com changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #2 from ***@gmail.com ---
Totally agree, highly required !
Which also means the current "Copy Frame" command should be renamed to "Clone
Current Frame" or something like that.

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=364162

Dmitry Kazakov <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #3 from Dmitry Kazakov <***@gmail.com> ---
I'm going to fix the issue by pasting the selection into an animated layer with
the same start and end time.

[Leonardo Kaempf]

https://bugs.kde.org/show_bug.cgi?id=364162

--- Comment #4 from Leonardo Kaempf <***@protonmail.com> ---
So, will it be possible to merge these Layers without loosing the frames?
What I mean is:
Will it be possible to merge pasted material into the frame I am working with?

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=364162

Dmitry Kazakov <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/kri
| |ta/eca15c47e552827ec9440ac8
| |bcc8140e4c38b601

--- Comment #5 from Dmitry Kazakov <***@gmail.com> ---
Git commit eca15c47e552827ec9440ac8bcc8140e4c38b601 by Dmitry Kazakov.
Committed on 13/04/2018 at 11:37.
Pushed by dkazakov into branch 'master'.

Fix copy-pasting pixel data from animated layers

Now when you copy-paste animated frame data, it is pasted into
exactly the same time range position. It means that if you later
merge down this data back to the original layer, you will not get
a data loss. The data will be merged exactly into the position where
it has been taken from.
CC:***@kde.org

M +18 -2 libs/ui/actions/KisPasteActionFactory.cpp
M +17 -3 libs/ui/actions/kis_selection_action_factories.cpp
M +30 -3 libs/ui/kis_clipboard.cc
M +4 -1 libs/ui/kis_clipboard.h

https://commits.kde.org/krita/eca15c47e552827ec9440ac8bcc8140e4c38b601

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=364162

Boudewijn Rempt <***@valdyas.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri
|ta/eca15c47e552827ec9440ac8 |ta/a4df42f88c2e9dd01e831102
|bcc8140e4c38b601 |70ba5bfdf939d408

--- Comment #6 from Boudewijn Rempt <***@valdyas.org> ---
Git commit a4df42f88c2e9dd01e83110270ba5bfdf939d408 by Boudewijn Rempt, on
behalf of Dmitry Kazakov.
Committed on 02/05/2018 at 11:54.
Pushed by rempt into branch 'krita/4.0'.

Fix copy-pasting pixel data from animated layers

Now when you copy-paste animated frame data, it is pasted into
exactly the same time range position. It means that if you later
merge down this data back to the original layer, you will not get
a data loss. The data will be merged exactly into the position where
it has been taken from.
CC:***@kde.org
(cherry picked from commit 39ec1d47a59425969814dc840209ec2433bdd133)

M +18 -2 libs/ui/actions/KisPasteActionFactory.cpp
M +17 -3 libs/ui/actions/kis_selection_action_factories.cpp
M +30 -3 libs/ui/kis_clipboard.cc
M +4 -1 libs/ui/kis_clipboard.h

https://commits.kde.org/krita/a4df42f88c2e9dd01e83110270ba5bfdf939d408