[konsole] [Bug 380455] New: Option to open new tab when splitting

[Gauthier POGAM--LE MONTAGNER]

https://bugs.kde.org/show_bug.cgi?id=380455

Bug ID: 380455
Summary: Option to open new tab when splitting
Product: konsole
Version: unspecified
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: split-view
Assignee: konsole-***@kde.org
Reporter: ***@gmail.com
Target Milestone: ---

Currently, it's not possible to easily split the screen and then open a new
tab, you need to do both operations separately.

I would like to have an option which create automatically a new tab when I
split screen. It exists on soft like tmux or terminator and I think it's really
useful as splitting and opening tab are two operations I often do together.

[Gauthier POGAM--LE MONTAGNER]

https://bugs.kde.org/show_bug.cgi?id=380455

Gauthier POGAM--LE MONTAGNER <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |wishlist

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=380455

Kurt Hindenburg <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|REPORTED |RESOLVED
Version Fixed In| |19.04
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/kon
| |sole/7a43e3b2cde05a70a38c0b
| |cac39051b675425bf9

--- Comment #1 from Kurt Hindenburg <***@gmail.com> ---
Git commit 7a43e3b2cde05a70a38c0bcac39051b675425bf9 by Kurt Hindenburg, on
behalf of Tomaz Canabrava.
Committed on 10/12/2018 at 15:02.
Pushed by hindenburg into branch 'master'.

Don't duplicate the tabs when Spliting the View

Summary:
Instead of iterating over the sessions to fetch the view and
duplicate the current screen once for each split, ignore all
of them and just create a new terminal view. The only thing
this terminal view shares with the previous current widget
is the profile.

use createView instead of manually trying to create the view

Fixes bug while closing the split

Don't duplicate tabs in the splits
Related: bug 385697
FIXED-IN: 19.04

Reviewers: thsurrel, hindenburg, gennad, ngraham, #konsole

Reviewed By: thsurrel, hindenburg, ngraham, #konsole

Subscribers: ngraham, hindenburg, gennad, konsole-devel

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D17267

M +11 -9 src/Application.cpp
M +20 -21 src/MainWindow.cpp
M +7 -4 src/MainWindow.h
M +3 -4 src/Part.cpp
M +6 -0 src/TerminalDisplay.cpp
M +13 -19 src/ViewContainer.cpp
M +4 -5 src/ViewContainer.h
M +35 -71 src/ViewManager.cpp
M +9 -5 src/ViewManager.h
M +12 -0 src/ViewSplitter.cpp

https://commits.kde.org/konsole/7a43e3b2cde05a70a38c0bcac39051b675425bf9