Discussion:
[kaffeine] [Bug 389783] New: DeInterlacing is enabled by default on HD channels and it is very slow
Add Reply
Valentin Zagura
2018-02-02 00:09:44 UTC
Reply
Permalink
https://bugs.kde.org/show_bug.cgi?id=389783

Bug ID: 389783
Summary: DeInterlacing is enabled by default on HD channels and
it is very slow
Product: kaffeine
Version: 2.0.13
Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: general
Assignee: mchehab+***@kernel.org
Reporter: ***@gmail.com
Target Milestone: ---

I spent a few hours investigating the very low framerate of HD channels in
Kaffeine until I've found out that deinterlacing was enabled by default.
I don't think the deinterlacing should be enabled by default, especially on HD
channels.
--
You are receiving this mail because:
You are watching all bug changes.
Mauro Carvalho Chehab
2018-02-20 14:48:58 UTC
Reply
Permalink
https://bugs.kde.org/show_bug.cgi?id=389783

--- Comment #1 from Mauro Carvalho Chehab <mchehab+***@kernel.org> ---
(In reply to Valentin Zagura from comment #0)
Post by Valentin Zagura
I spent a few hours investigating the very low framerate of HD channels in
Kaffeine until I've found out that deinterlacing was enabled by default.
I don't think the deinterlacing should be enabled by default, especially on
HD channels.
Not sure how to fix it. Kaffeine doesn't know if the hardware is fast enough
for de-interlacing a certain video. Depending on the GPU, de-interlacing can
happen inside it.

In other words, the entire de-interlacing and GPU performance is handled by
libVLC.
--
You are receiving this mail because:
You are watching all bug changes.
Mauro Carvalho Chehab
2018-02-20 18:04:18 UTC
Reply
Permalink
https://bugs.kde.org/show_bug.cgi?id=389783

Mauro Carvalho Chehab <mchehab+***@kernel.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED

--- Comment #2 from Mauro Carvalho Chehab <mchehab+***@kernel.org> ---
After thinking about that, I ended by adding this patch:

https://commits.kde.org/kaffeine/73307da9a81bebbfae745e715c097104914963fc

It improves de-interlacing selection and sets default to not interlace:

Git commit 73307da9a81bebbfae745e715c097104914963fc by Mauro Carvalho Chehab.
Committed on 20/02/2018 at 17:58.
Pushed by mauroc into branch 'master'.

mediawidget: allow better control of deinterlacing mode

Instead of just on/off, allow setting the de-interlacing mode
to the types supported by libVLC.

Also changes default to not do deinterlacing, as most TV programs
nowadays are in progressive mode, and doing de-interlacing on
4K programs can be a very CPU intensive task.

Signed-off-by: Mauro Carvalho Chehab <***@s-opensource.com>

M +1 -1 doc/index.docbook
M +2 -2 src/abstractmediawidget.h
M +3 -6 src/backend-mplayer/mplayermediawidget.cpp
M +2 -2 src/backend-mplayer/mplayermediawidget.h
M +36 -5 src/backend-vlc/vlcmediawidget.cpp
M +1 -1 src/backend-vlc/vlcmediawidget.h
M +135 -28 src/mediawidget.cpp
M +17 -2 src/mediawidget.h
--
You are receiving this mail because:
You are watching all bug changes.
Mauro Carvalho Chehab
2018-11-08 10:26:07 UTC
Reply
Permalink
https://bugs.kde.org/show_bug.cgi?id=389783

Mauro Carvalho Chehab <mchehab+***@kernel.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@live.de

--- Comment #3 from Mauro Carvalho Chehab <mchehab+***@kernel.org> ---
*** Bug 387750 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
Mauro Carvalho Chehab
2018-11-08 18:29:09 UTC
Reply
Permalink
https://bugs.kde.org/show_bug.cgi?id=389783

Mauro Carvalho Chehab <mchehab+***@kernel.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #4 from Mauro Carvalho Chehab <mchehab+***@kernel.org> ---
*** Bug 397532 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
Loading...