Discussion:
[kate] [Bug 391518] New: Cursor width in Kate gets narrower every 16 characters
(too old to reply)
David de Cos
2018-03-07 12:28:21 UTC
Permalink
Raw Message
https://bugs.kde.org/show_bug.cgi?id=391518

Bug ID: 391518
Summary: Cursor width in Kate gets narrower every 16 characters
Product: kate
Version: 17.12.0
Platform: Neon Packages
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: general
Assignee: kwrite-bugs-***@kde.org
Reporter: ***@ehu.eus
Target Milestone: ---

Created attachment 111245
--> https://bugs.kde.org/attachment.cgi?id=111245&action=edit
Two screenshots put together, where both widths can be seen

The width of the cursor in Kate depends on what column it is in. Most of the
times its quite thick, but at some places of the document it's narrower.

The column numbers where it is narrow are: 1, 17, 33, 49, 65, 81, 97... (i.e.
16*n+1)

It's not a severe bug, but I find it slightly annoying, and the fact that those
column numbers follow a mathematical pattern makes it interesting!
--
You are receiving this mail because:
You are watching all bug changes.
Christoph Feck
2018-03-29 22:45:57 UTC
Permalink
Raw Message
https://bugs.kde.org/show_bug.cgi?id=391518

Christoph Feck <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0 |1

--- Comment #1 from Christoph Feck <***@kde.org> ---
The issue is that QTextLayout uses QPainter::RasterOp_NotDestination, which
means all pixels that are affected by the cursor rect get inverted. Since the
cursor rect is positioned at fractional positions, usually 3 instead of 2
pixels get inverted.

I suggest to use setRenderHint(QPainter::Antialiasing, false) for the cursor.
This way, the rect rasterization will be pixel-aligned and only the intended 2
pixels get inverted.
--
You are receiving this mail because:
You are watching all bug changes.
Christoph Feck
2018-04-26 21:33:47 UTC
Permalink
Raw Message
https://bugs.kde.org/show_bug.cgi?id=391518

Christoph Feck <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Keywords| |junior-jobs
--
You are receiving this mail because:
You are watching all bug changes.
b***@kde.org
2018-05-28 16:03:07 UTC
Permalink
Raw Message
https://bugs.kde.org/show_bug.cgi?id=391518

***@gmail.com changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com
Assignee|kwrite-bugs-***@kde.org |***@gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
b***@kde.org
2018-05-28 16:54:41 UTC
Permalink
Raw Message
https://bugs.kde.org/show_bug.cgi?id=391518

--- Comment #2 from ***@gmail.com ---
I'm able to reproduce this bug and I will try to fix the issue.
--
You are receiving this mail because:
You are watching all bug changes.
Oleh Prypin
2018-05-31 22:48:46 UTC
Permalink
Raw Message
https://bugs.kde.org/show_bug.cgi?id=391518

Oleh Prypin <***@pryp.in> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@pryp.in

--- Comment #3 from Oleh Prypin <***@pryp.in> ---
For me, the cursor appears thinner only at columns 1, 65, 129, ...
Another person reported the same (this was in IRC)

I'd like to note that I would prefer this to be fixed in the direction of
making the cursor always thinner, rather than always thicker.
--
You are receiving this mail because:
You are watching all bug changes.
b***@kde.org
2018-06-05 13:55:51 UTC
Permalink
Raw Message
https://bugs.kde.org/show_bug.cgi?id=391518

--- Comment #5 from ***@gmail.com ---
Thank you C feck, I was trying to find the bug in Kate for 3 days:(
Post by David de Cos
https://bugs.kde.org/show_bug.cgi?id=391518
What |Removed |Added
------------------------------------------------------------
----------------
Product|kate |frameworks-ktexteditor
Version|17.12.0 |unspecified
Component|general |general
Reassigning to affected repository to help juniors finding the code.
--
You are on the CC list for the bug.
You are the assignee for the bug.
--
You are receiving this mail because:
You are watching all bug changes.
Nate Graham
2018-06-05 16:59:40 UTC
Permalink
Raw Message
https://bugs.kde.org/show_bug.cgi?id=391518

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@kde.org
--
You are receiving this mail because:
You are watching all bug changes.
Sven Brauch
2018-06-07 07:08:29 UTC
Permalink
Raw Message
https://bugs.kde.org/show_bug.cgi?id=391518

Sven Brauch <***@svenbrauch.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/kte
| |xteditor/e6f87dd570082eb7f6
| |36b92f6ca88d85763ae687
Resolution|--- |FIXED

--- Comment #6 from Sven Brauch <***@svenbrauch.de> ---
Git commit e6f87dd570082eb7f636b92f6ca88d85763ae687 by Sven Brauch, on behalf
of Shubham Jangra.
Committed on 07/06/2018 at 07:07.
Pushed by brauch into branch 'master'.

Fix caret width

Differential Revision: https://phabricator.kde.org/D13365

M +1 -0 src/render/katerenderer.cpp

https://commits.kde.org/ktexteditor/e6f87dd570082eb7f636b92f6ca88d85763ae687
--
You are receiving this mail because:
You are watching all bug changes.
Christoph Feck
2018-06-04 19:43:05 UTC
Permalink
Raw Message
https://bugs.kde.org/show_bug.cgi?id=391518

Christoph Feck <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Product|kate |frameworks-ktexteditor
Version|17.12.0 |unspecified
Component|general |general

--- Comment #4 from Christoph Feck <***@kde.org> ---
Reassigning to affected repository to help juniors finding the code.
--
You are receiving this mail because:
You are watching all bug changes.
Loading...