[krita] [Bug 391789] New: Uniform Scaling doesn't work using the input boxes on the vector widget

[mvowada]

https://bugs.kde.org/show_bug.cgi?id=391789

Bug ID: 391789
Summary: Uniform Scaling doesn't work using the input boxes on
the vector widget
Product: krita
Version: git master
Platform: Appimage
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: Tools
Assignee: krita-bugs-***@kde.org
Reporter: ***@tiscali.it
Target Milestone: ---

(Krita 4.1.0-pre-alpha (git d0e6714) appimage)

With a vector shape selected on canvas:

1) enable "Tool Options" > "Geometry" tab > "Uniform Scaling"
2) type in a different value

Actual Results: it doesn't scale uniformly
Expected results: scale uniformly

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=391789

Boudewijn Rempt <***@valdyas.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@valdyas.org
Assignee|krita-bugs-***@kde.org |***@gmail.com

--- Comment #1 from Boudewijn Rempt <***@valdyas.org> ---
Dmitry,

Can you check this report?

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=391789

Dmitry Kazakov <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |WORKSFORME
Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Dmitry Kazakov <***@gmail.com> ---
Hi, mvowada!

I've just tested, Uniform Scaling works as expected. I guess the problem is in
the naming of this option. "Uniform Scaling" doesn't mean that aspect ratio of
the shape will be intact, it means that the shape will be **scaled** instead of
**resized**, that is, the stroke of the shape will be scaled alongside the size
of the shape itself.

Although we have a note about it in the manual [1], I guess we should rename
the option into something more intuitive after the release...

[1] - https://docs.krita.org/Shape_Selection_Tool

[mvowada]

https://bugs.kde.org/show_bug.cgi?id=391789

--- Comment #3 from mvowada <***@tiscali.it> ---
Created attachment 111395
--> https://bugs.kde.org/attachment.cgi?id=111395&action=edit
(Video example)

Thanks for the clear reply.

I'm sorry, I realize I had not read what the "Uniform Scaling" option was for,
making the mistake of confusing it with the "block ratio" function (the chain
toggle button).

Revised steps:

1) 'toggle' the "Tool Options"> "Geometry" tab > chain button, to activate
it
2) type in a different value

I made also a short video to better explain the problem I wanted to report.

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=391789

--- Comment #4 from Dmitry Kazakov <***@gmail.com> ---
Git commit 9636544a7c051e1a36710e505144ac7098b40dc5 by Dmitry Kazakov.
Committed on 14/03/2018 at 15:42.
Pushed by dkazakov into branch 'master'.

Krita 4.1-only: Rename "Uniform Scaling" into "Scale Styles"

People are confused with the term "uniform scaling", they think
that it is about aspect ratio locking, but it is not.

We cannot push that to 4.0 because of the string freeze, but
we can change that for 4.1

CC:***@kde.org

M +1 -1
plugins/tools/defaulttool/defaulttool/DefaultToolGeometryWidget.ui

https://commits.kde.org/krita/9636544a7c051e1a36710e505144ac7098b40dc5

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=391789

Dmitry Kazakov <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Ever confirmed|0 |1
Resolution|WORKSFORME |---

--- Comment #5 from Dmitry Kazakov <***@gmail.com> ---
Okay, I can reproduce the bug in a video

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=391789

Dmitry Kazakov <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REOPENED |RESOLVED
Latest Commit| |https://commits.kde.org/kri
| |ta/4edb8074b8d04525f8113e43
| |24705eca6806ebd3

--- Comment #6 from Dmitry Kazakov <***@gmail.com> ---
Git commit 4edb8074b8d04525f8113e4324705eca6806ebd3 by Dmitry Kazakov.
Committed on 14/03/2018 at 16:16.
Pushed by dkazakov into branch 'master'.

Fix aspect locking when resizing the shapes

M +1 -3
plugins/tools/defaulttool/defaulttool/DefaultToolGeometryWidget.cpp

https://commits.kde.org/krita/4edb8074b8d04525f8113e4324705eca6806ebd3

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=391789

--- Comment #7 from Dmitry Kazakov <***@gmail.com> ---
The bug should finally be fixed! Thank you for your report, mvowada! :)

[mvowada]

https://bugs.kde.org/show_bug.cgi?id=391789

--- Comment #8 from mvowada <***@tiscali.it> ---
Thank you :)

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=391789

Boudewijn Rempt <***@valdyas.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri
|ta/4edb8074b8d04525f8113e43 |ta/25082a541af6fc3eaf9ceaf4
|24705eca6806ebd3 |25bc38d4c16f671f

--- Comment #9 from Boudewijn Rempt <***@valdyas.org> ---
Git commit 25082a541af6fc3eaf9ceaf425bc38d4c16f671f by Boudewijn Rempt, on
behalf of Dmitry Kazakov.
Committed on 14/03/2018 at 17:48.
Pushed by rempt into branch 'krita/4.0'.

Fix aspect locking when resizing the shapes

M +1 -3
plugins/tools/defaulttool/defaulttool/DefaultToolGeometryWidget.cpp

https://commits.kde.org/krita/25082a541af6fc3eaf9ceaf425bc38d4c16f671f