[frameworks-plasma] [Bug 391821] New: Icon of mobile broadband network is sometimes wrong

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

Bug ID: 391821
Summary: Icon of mobile broadband network is sometimes wrong
Product: frameworks-plasma
Version: 5.43.0
Platform: Manjaro
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: libplasma
Assignee: ***@gmail.com
Reporter: ***@gmail.com
Target Milestone: ---

Created attachment 111368
--> https://bugs.kde.org/attachment.cgi?id=111368&action=edit
network-folder

I use Papirus icon pack on Manjaro (community/papirus-icon-theme) but sometimes
broadband icon is wrong - it shows network folder instead.

It happens rarely ONLY with broadband network - neither with Wifi or with LAN.

When I was using Kubuntu I have never met such issue.
Since the time I started to use Manjaro KDE I sometimes face this issue.

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=391821

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@kde.org
Status|UNCONFIRMED |NEEDSINFO
Resolution|--- |WAITINGFORINFO

--- Comment #1 from Nate Graham <***@kde.org> ---
Does the issue reproduce using standard Breeze icons?

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #2 from Petr Nehez <***@gmail.com> ---
Created attachment 111375
--> https://bugs.kde.org/attachment.cgi?id=111375&action=edit
network-folder-ubuntu

When I set Breeze, I had even no icon there.

And when I set Ubuntu icons, I had network folder there as well.

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #3 from Petr Nehez <***@gmail.com> ---
Created attachment 111376
--> https://bugs.kde.org/attachment.cgi?id=111376&action=edit
network-folder-breeze

This is screenshot with empty icon...

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #4 from Petr Nehez <***@gmail.com> ---
Strange thing is that icons of plasmoids have not been updated.
I deleted cache, restarted system...

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=391821

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDSINFO |UNCONFIRMED
Resolution|WAITINGFORINFO |---

--- Comment #5 from Nate Graham <***@kde.org> ---
Thanks for the info.

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #6 from Petr Nehez <***@gmail.com> ---
Created attachment 111384
--> https://bugs.kde.org/attachment.cgi?id=111384&action=edit
network-folder-breeze-2

I changed Look & Feel theme to Breeze Dark because I forgot that plasmoid icons
are driven by that but as you can see there is the same issue.

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #7 from Petr Nehez <***@gmail.com> ---
Created attachment 111388
--> https://bugs.kde.org/attachment.cgi?id=111388&action=edit
lan-network

I am now connected via LAN and the icon is with red circle.

I was connecting & disconnecting to LAN and/or WiFi because I had some issue
with the specific WiFi and after disconnecting from WiFi it ended up with this
crossed LAN icon.

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=391821

Christoph Feck <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Product|frameworks-plasma |plasma-nm
Version|5.43.0 |5.12.3
Assignee|***@gmail.com |***@redhat.com
CC| |***@gmail.com
Component|libplasma |general

--- Comment #8 from Christoph Feck <***@kde.org> ---
Not sure where to reassign to, but I guess plasma-nm developers and VDG team
can coordinate this.

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #9 from Petr Nehez <***@gmail.com> ---
If anybody wants a help I am here as it annoys me.

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

Petr Nehez <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |plasma-***@kde.org

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #10 from Petr Nehez <***@gmail.com> ---
Is here anybody who could fix this issue?
I can be helpful on it...

[Jan Grulich]

https://bugs.kde.org/show_bug.cgi?id=391821

Jan Grulich <***@redhat.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@redhat.com

--- Comment #11 from Jan Grulich <***@redhat.com> ---
This seem to be a problem in theme, I would change Plasma theme to "Breeze
dark", just the theme, no need to change Look & Feel completely and restart
plasmashell.

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #12 from Petr Nehez <***@gmail.com> ---
OK, I have changed the theme and will be watching it.
But the weird thing is that sometimes the icon is correct but in most cases
it's not.

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #13 from Petr Nehez <***@gmail.com> ---
Created attachment 112648
--> https://bugs.kde.org/attachment.cgi?id=112648&action=edit
network-with-breeze

It seemed OK with Breeze theme until I was on EDGE with VPN and after
disconnecting of VPN the network icon was shown.
But after a while when I was preparing this screenshot it got fixed to correct
mobile network icon (most likely due to a change from EDGE to 4G/LTE).

[Jan Grulich]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #14 from Jan Grulich <***@redhat.com> ---
If I provide a patch adding some debug information, would you be able to
compile plasma-nm with it?

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #15 from Petr Nehez <***@gmail.com> ---
I would try that although I have not compiled any regular package yet.

I am on Manjaro where my plasma-nm is 5.12.5 so I guess I should clone
https://cgit.kde.org/plasma-nm.git/log/?h=Plasma/5.12 and then apply a patch?

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #16 from Petr Nehez <***@gmail.com> ---
OK, I cloned the repo and could compile plasma-nm with this cmake command:

cmake ../ -DCMAKE_INSTALL_PREFIX=/usr

I did not try to install it yet so I can try your patch.
Hopefully my system won't break then 'cause I would break my working env :)

[Jan Grulich]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #17 from Jan Grulich <***@redhat.com> ---
Created attachment 112661
--> https://bugs.kde.org/attachment.cgi?id=112661&action=edit
Patch adding some debug information

Apply please attached patch. Then please follow information from here
https://techbase.kde.org/Projects/Solid/Plasma-nm, specifically part with
QT_LOGGING_CATEGORY.

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #18 from Petr Nehez <***@gmail.com> ---
I don't see anything about QT_LOGGING_CATEGORY there.
Did you mean QT_LOGGING_RULES?

[Jan Grulich]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #19 from Jan Grulich <***@redhat.com> ---
Yes, sorry for confusion.

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #20 from Petr Nehez <***@gmail.com> ---
I compiled it with the applied patch,d added "export
QT_LOGGING_RULES=plasma-nm*.debug=true" into my .profile file and restarted my
system.

Could you help me now where I should see log output?

[Jan Grulich]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #21 from Jan Grulich <***@redhat.com> ---
You have to open a terminal and restart plasmashell from there, I usually do
"killall plasmashell" and then you can just run "plasmashell", then you should
get debug output from plasma-nm. It's described also in the link I sent you
before.

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #22 from Petr Nehez <***@gmail.com> ---
Created attachment 112701
--> https://bugs.kde.org/attachment.cgi?id=112701&action=edit
bad-icon.log

It took me a while to replicate it but finally I got the bad icon.

Could it be caused that the modem driver is not responding with the correct
signal value?
As you can see there are only 0 values.
I can tell you that the real signal is over 90, in the previous logs I could
see the value 93, but that value appeared when I disconnetced and connected to
the modem several times.

And what about the icon "network-mobile-0-lte-limited"?
Isn't it that issue?

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #24 from Petr Nehez <***@gmail.com> ---
And when I connected to VPN (a lock appeared on a modem icon) and then
disconnected it, the icon changed to 0-signal modem icon.

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #23 from Petr Nehez <***@gmail.com> ---
I forgot to mention that the connection is working fine when it reports
Signal=0.

[Jan Grulich]

https://bugs.kde.org/show_bug.cgi?id=391821

Jan Grulich <***@redhat.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #112661|0 |1
is obsolete| |

--- Comment #25 from Jan Grulich <***@redhat.com> ---
Created attachment 112923
--> https://bugs.kde.org/attachment.cgi?id=112923&action=edit
Patch adding some debug information

Can you please try this patch with more debug information. I still have no idea
why this is happening.

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #26 from Petr Nehez <***@gmail.com> ---
I applied the patch to the master branch and installed the package.

I think the issue is noticeable in areas with weak signal so when I am
travelling with the train I will be testing it.

Now when I am in the office and the mobile signal is strong and I play with
connecting & disconnecting to/from LAN and/or Wifi and/or mobile I am not able
to replicate the issue. I will let you know.

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #27 from Petr Nehez <***@gmail.com> ---
I was trying to replicate the issue again but unfortunately my modem was not
reporting "limited" or "zero" signal for few days what I could see so far.

Isn't the real issue that there are no icons for the suffix "-limited"?

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #28 from Petr Nehez <***@gmail.com> ---
I am running Plasma with the patched plasma-nm package already for 2 days (with
few suspend & resume actions every day) and when I was on modem connection only
(in a train) I spent approx 1 hour trying to replicate the issue.

It could be just an issue of my modem which was reporting wrong signal value or
an issue of the driver, who knows?

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #29 from Petr Nehez <***@gmail.com> ---
Created attachment 113132
--> https://bugs.kde.org/attachment.cgi?id=113132&action=edit
plasma-log-limited

Finally after few days I've got the icon for limited signal.
See the attached log.

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #30 from Petr Nehez <***@gmail.com> ---
Created attachment 113133
--> https://bugs.kde.org/attachment.cgi?id=113133&action=edit
plasma-log-limited-2

And what is strange that the icon in the plasmoid was not change even I could
see in the terminal that modem is reporting signal strength at 60%.

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #31 from Petr Nehez <***@gmail.com> ---
So actually it turned out to be an issue between NM and icons set.

When I created the following symlinks, the icon started to work.

network-mobile-0-lte-limited.svg -> network-cellular-signal-good.svg
network-mobile-0-lte.svg -> network-cellular-signal-good.svg
network-mobile-100-lte.svg -> network-cellular-signal-good.svg
network-mobile-40-lte.svg -> network-cellular-signal-good.svg
network-mobile-60-lte.svg -> network-cellular-signal-good.svg
network-mobile-80-lte.svg -> network-cellular-signal-good.svg

But I do not think creating of such symlinks for in each possible icon set
would be the best approach.

What if NM would start using of "network-cellular-signal-*" icons?

[Jan Grulich]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #32 from Jan Grulich <***@redhat.com> ---
This is weird, we don't use "network-cellular-signal-good" icon name. This
looks like your distribution has some custom modifications to plasma-nm applet.

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #33 from Petr Nehez <***@gmail.com> ---
OK, my bad - "network-cellular-signal-*" icons are from Papirus icons set.

But the point is that if make such symlinks (to any existing icon from Breeze
theme) the icon starts to work again.

I have checked https://cgit.kde.org/breeze-icons.git/tree/icons-dark/status/22
and I cannot see there any "network-mobile-*" icon.

[Jan Grulich]

https://bugs.kde.org/show_bug.cgi?id=391821

Jan Grulich <***@redhat.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|REPORTED |RESOLVED
Resolution|--- |NOT A BUG

--- Comment #34 from Jan Grulich <***@redhat.com> ---
The icons are from plasma theme, they are all stored in one svg. If you want to
use a different icons, you need to make sure that all of them are there. If the
icon set is not complete, you need to workaround it the way you did or use a
different icon set.

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #35 from Petr Nehez <***@gmail.com> ---
And could you help me where in Breeze theme/icons I can find such icons?

[Jan Grulich]

https://bugs.kde.org/show_bug.cgi?id=391821

--- Comment #36 from Jan Grulich <***@redhat.com> ---
They are in plasma-framework:
https://cgit.kde.org/plasma-framework.git/tree/src/desktoptheme/breeze/icons/network.svgz

[Petr Nehez]

https://bugs.kde.org/show_bug.cgi?id=391821

Petr Nehez <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED

--- Comment #37 from Petr Nehez <***@gmail.com> ---
Thanks, I see.