[okular] [Bug 321992] Feature request: Can the highlighter automatically fill the attached pop-up note with highlighted text.

[Stephen Ewen]

https://bugs.kde.org/show_bug.cgi?id=321992

--- Comment #1 from Stephen Ewen <stephen.ewen-***@public.gmane.org> ---
Created attachment 81145
--> https://bugs.kde.org/attachment.cgi?id=81145&action=edit
Okular, Docear, & UberStudent - implementation conversation

Yes, this feature request is very important!

Please see the attached conversation between myself and the Docear lead
developer about it.

Coding this fix myself is beyond my own ability or I'd do it myself.

[Kirill I. Krasnoschekov]

https://bugs.kde.org/show_bug.cgi?id=321992

Kirill I. Krasnoschekov <krvkir-***@public.gmane.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |krvkir-***@public.gmane.org

--- Comment #2 from Kirill I. Krasnoschekov <krvkir-***@public.gmane.org> ---
I use Okular with Docear too and approve that this feature will be very helpful
for good integration with Docear.

[Tyler Smith]

https://bugs.kde.org/show_bug.cgi?id=321992

Tyler Smith <sedgeboy-***@public.gmane.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |sedgeboy-***@public.gmane.org

[s***@yahoo.de]

https://bugs.kde.org/show_bug.cgi?id=321992

***@yahoo.de changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@yahoo.de

--- Comment #3 from ***@yahoo.de ---
This feature is somewhat necessary for a productive use of Okular together with
Docear. I very much whish for this feature !

[John]

https://bugs.kde.org/show_bug.cgi?id=321992

John <12zty8+***@sharklasers.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |12zty8+***@sharkl
| |asers.com

[John SQ Liu]

https://bugs.kde.org/show_bug.cgi?id=321992

John SQ Liu <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #4 from John SQ Liu <***@gmail.com> ---
Hello I'm an Okular and Docear user. I modified a few lines in
ui/pageviewannotator.cpp's TextSelectorEngine to implement the requested
feature. Would you be interested in including it as default behavior or
potentially as a menu option?

[Kirill I. Krasnoschekov]

https://bugs.kde.org/show_bug.cgi?id=321992

--- Comment #5 from Kirill I. Krasnoschekov <***@gmail.com> ---
I would prefer to make it the default behaviour as I can't imagine the
situation where this pasted text can harm someone. (But developers may have
different opinions.)

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=321992

Albert Astals Cid <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@kde.org

--- Comment #6 from Albert Astals Cid <***@kde.org> ---
On the other hand i can't imagine a situation in which i would want that, this
just looks like you're trying to fix a limitation in docear making okular do
something weird.

I mean i am highlighting the text, as a user why would i want the note of that
highlighted text be the test himself?

[Kirill I. Krasnoschekov]

https://bugs.kde.org/show_bug.cgi?id=321992

--- Comment #7 from Kirill I. Krasnoschekov <***@gmail.com> ---
This sounds reasonable. But at least having this behaviour as an option
wouldn't go amiss.

(Maybe it's too complicated to fetch the text which was highlighted from Docear
or any other external applicaion, I don't know.)

[John SQ Liu]

https://bugs.kde.org/show_bug.cgi?id=321992

--- Comment #8 from John SQ Liu <***@gmail.com> ---
If you need to export annotations, this would give access to highlight text
in the XML output.

Post by Stephen Ewen
https://bugs.kde.org/show_bug.cgi?id=321992
What |Removed |Added
----------------------------------------------------------------------------
On the other hand i can't imagine a situation in which i would want that,
this
just looks like you're trying to fix a limitation in docear making okular
do
something weird.
I mean i am highlighting the text, as a user why would i want the note of
that
highlighted text be the test himself?
--
You are on the CC list for the bug.

[Chris George]

https://bugs.kde.org/show_bug.cgi?id=321992

Chris George <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #9 from Chris George <***@gmail.com> ---
I am working with a text editor/outliner to create academic papers. Having the
content of highlighted text appear in the xml metadata would be immensely
useful and save considerable time and effort when summarizing papers.

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=321992

***@trbvm.com changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@trbvm.com

--- Comment #10 from ***@trbvm.com ---
@John SQ Liu: Are you willing to publish your implementation
(ui/pageviewannotator.cpp) of the feature for those who are able to compile the
source code by themselves? Gist.github.com would be a good idea.

[John SQ Liu via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=321992

--- Comment #11 from John SQ Liu <***@gmail.com> ---
I no longer use Docear (I moved to emacs and org-mode) so this off of a version
of Okular in March. But it's a 4 line change so you might be able to merge it
without too much work. Diff below

https://github.com/jsqliu/okular/commit/ee9a8f5272c1ea4b20648fe57b52c726751073aa

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=321992

--- Comment #12 from ***@trbvm.com ---
Thanks, it works perfectly.

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=321992

***@alshu.de changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0 |1

--- Comment #13 from ***@alshu.de ---
*** This bug has been confirmed by popular vote. ***

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=321992

Oliver Sander <***@tu-dresden.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@tu-dresden.de

--- Comment #14 from Oliver Sander <***@tu-dresden.de> ---
It's not me who decides what goes into okular and what doesn't, but I know that
your chances increase if you upload the patch to
https://git.reviewboard.kde.org .